commit 2a4b2fa75d06a097261a02ecd3cf2b6d449bf754
author Lasse Collin <lasse.collin@tukaani.org> Thu Mar 30 22:01:54 2017 +0300
committer Lasse Collin <lasse.collin@tukaani.org> Thu Mar 30 22:02:10 2017 +0300
tree 55a04d3f68ac7b5a8c4cdb7928cb7bae9cf140a6
parent eb25743ade39170cffd9566a1aae272098cce216

xz: Use POSIX_FADV_RANDOM for in "xz --list" mode.

xz --list is random access so POSIX_FADV_SEQUENTIAL was clearly
wrong.

src/xz/file_io.c

diff --git a/src/xz/file_io.c b/src/xz/file_io.c
index c01f4e8..041bed8 100644
--- a/src/xz/file_io.c
+++ b/src/xz/file_io.c
@@ -525,7 +525,10 @@
 #endif
 #ifdef HAVE_POSIX_FADVISE
 		// It will fail if stdin is a pipe and that's fine.
-		(void)posix_fadvise(STDIN_FILENO, 0, 0, POSIX_FADV_SEQUENTIAL);
+		(void)posix_fadvise(STDIN_FILENO, 0, 0,
+				opt_mode == MODE_LIST
+					? POSIX_FADV_RANDOM
+					: POSIX_FADV_SEQUENTIAL);
 #endif
 		return false;
 	}
@@ -716,7 +719,10 @@
 
 #ifdef HAVE_POSIX_FADVISE
 	// It will fail with some special files like FIFOs but that is fine.
-	(void)posix_fadvise(pair->src_fd, 0, 0, POSIX_FADV_SEQUENTIAL);
+	(void)posix_fadvise(pair->src_fd, 0, 0,
+			opt_mode == MODE_LIST
+				? POSIX_FADV_RANDOM
+				: POSIX_FADV_SEQUENTIAL);
 #endif
 
 	return false;