tree 4054f8726988c6a16264b34d6b630c6597077cda
parent 226364766f936d249e408de03821468c1bf11dda
author Linus Torvalds <torvalds@linux-foundation.org> 1358742178 -0800
committer Linus Torvalds <torvalds@linux-foundation.org> 1358742178 -0800

module: fix missing module_mutex unlock

Commit 1fb9341ac348 ("module: put modules in list much earlier") moved
some of the module initialization code around, and in the process
changed the exit paths too.  But for the duplicate export symbol error
case the change made the ddebug_cleanup path jump to after the module
mutex unlock, even though it happens with the mutex held.

Rusty has some patches to split this function up into some helper
functions, hopefully the mess of complex goto targets will go away
eventually.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>