commit c569d3326bca6774f6c23f1dc91acad5400b6409
author Frederik Deweerdt <frederik.deweerdt@xprog.eu> Thu Sep 23 22:19:01 2010 +0200
committer Arnaldo Carvalho de Melo <acme@redhat.com> Mon Oct 04 12:08:37 2010 -0300
tree b0d5af7c01a2082cb187101d1de16103f2446e1f
parent 39cfae64dfd243fa7a7ca73643591bdebc1cf1e9

perf ui hist browser: Fix segfault on 'a' for annotate

There a typo in util/ui/browsers/hists.c that leads to a segfault when you
press the 'a' key on a non-resolved symbol (plain hex address).

LKML-Reference: <20100923201901.GE31726@gambetta>
Signed-off-by: Frederik Deweerdt <frederik.deweerdt@xprog.eu>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

tools/perf/util/ui/browsers/hists.c

diff --git a/tools/perf/util/ui/browsers/hists.c b/tools/perf/util/ui/browsers/hists.c
index dafdf67..6866aa4 100644
--- a/tools/perf/util/ui/browsers/hists.c
+++ b/tools/perf/util/ui/browsers/hists.c
@@ -773,7 +773,7 @@
 
 			switch (key) {
 			case 'a':
-				if (browser->selection->map == NULL &&
+				if (browser->selection->map == NULL ||
 				    browser->selection->map->dso->annotate_warned)
 					continue;
 				goto do_annotate;