commit bcda432194fc7c4a2dbe9d7146f00b4b21e66c8c
author Axel Lin <axel.lin@gmail.com> Thu Dec 29 17:02:08 2011 +0800
committer Mark Brown <broonie@opensource.wolfsonmicro.com> Thu Dec 29 10:40:19 2011 +0000
tree 24ac992ed9dc5768f3f890543b40d59a86ab06ed
parent a398eaa23e42b73216efbe03dc1d754b2e5d603c

regulator: Fix the error handling if create_regulator fails

In the case of create_regulator() fails, goto the error path immediately.
It does not make sense to update rdev->open_count if create_regulator fails.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

drivers/regulator/core.c

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 6f7d411..6cb9d39 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -1282,6 +1282,7 @@
 	if (regulator == NULL) {
 		regulator = ERR_PTR(-ENOMEM);
 		module_put(rdev->owner);
+		goto out;
 	}
 
 	rdev->open_count++;