commit aa7a74040a989eeb7a9265550a2538863e842a93
author Axel Lin <axel.lin@gmail.com> Fri Nov 05 15:25:12 2010 +0800
committer Liam Girdwood <lrg@slimlogic.co.uk> Tue Nov 30 15:13:25 2010 +0000
tree 6068b9432ed1933ad5829039b5fd902076b8ef5d
parent 59c700cf20a6eefb68187df3468ffa0b11d5e9a4

regulator: Remove a redundant device_remove_file call in create_regulator

We already have device_remove_file() in error path,
no need to call it before goto link_name_err.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>

drivers/regulator/core.c

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index c625633..c3f93b4 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -1052,7 +1052,6 @@
 			printk(KERN_WARNING
 			       "%s: could not add device link %s err %d\n",
 			       __func__, dev->kobj.name, err);
-			device_remove_file(dev, &regulator->dev_attr);
 			goto link_name_err;
 		}
 	}