commit a50f7951a31d3b976e829250853f89c9d2da32c0
author Trond Myklebust <Trond.Myklebust@netapp.com> Tue Jun 05 19:23:43 2007 -0400
committer Trond Myklebust <Trond.Myklebust@netapp.com> Tue Jul 10 23:40:25 2007 -0400
tree de9e8a3f93ee724471a49d9edb1155adef8d41f5
parent e2f032e9ef66e33089d09452892696ea97d1dca1

NFS: Fix an Oops in the nfs_access_cache_shrinker()

The nfs_access_cache_shrinker may race with nfs_access_zap_cache().

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

fs/nfs/dir.c

diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
index 0f41678..322141f 100644
--- a/fs/nfs/dir.c
+++ b/fs/nfs/dir.c
@@ -1743,8 +1743,8 @@
 	struct nfs_inode *nfsi;
 	struct nfs_access_entry *cache;
 
-	spin_lock(&nfs_access_lru_lock);
 restart:
+	spin_lock(&nfs_access_lru_lock);
 	list_for_each_entry(nfsi, &nfs_access_lru_list, access_cache_inode_lru) {
 		struct inode *inode;
 
@@ -1769,6 +1769,7 @@
 			clear_bit(NFS_INO_ACL_LRU_SET, &nfsi->flags);
 		}
 		spin_unlock(&inode->i_lock);
+		spin_unlock(&nfs_access_lru_lock);
 		iput(inode);
 		goto restart;
 	}