commit a29fa9dfa4d5d1b962825c79f19d9b6f3f15843b
author Artem Bityutskiy <Artem.Bityutskiy@nokia.com> Thu May 26 09:43:34 2011 +0300
committer Artem Bityutskiy <dedekind1@gmail.com> Mon Jul 04 10:54:26 2011 +0300
tree bd7aa3733a869c69038b4474229fbc9ada002cbf
parent 1b51e98365e42c27eb2664f8353bc62ab8c55c85

UBIFS: minor cleanup: use S_ISREG helper

Instead of using long "(inode->i_mode & S_IFMT) != S_IFREG" expression, use
shorted "!S_ISREG(inode->i_mode)".

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

fs/ubifs/super.c

diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index de82c5d..2850385 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -85,7 +85,7 @@
 	if (ui->data_len < 0 || ui->data_len > UBIFS_MAX_INO_DATA)
 		return 4;
 
-	if (ui->xattr && (inode->i_mode & S_IFMT) != S_IFREG)
+	if (ui->xattr && !S_ISREG(inode->i_mode))
 		return 5;
 
 	if (!ubifs_compr_present(ui->compr_type)) {