commit 939205b27312b7d7c4c55624ba785e554b39ecbb
author Antonino A. Daplas <adaplas@gmail.com> Sat Mar 11 03:27:23 2006 -0800
committer Linus Torvalds <torvalds@g5.osdl.org> Sat Mar 11 09:19:35 2006 -0800
tree 120591e604a08ed56b86b3c6bb86bce4abba7461
parent 16afe814a856e271628c5dfb4abbc318ec6b6f5f

[PATCH] arcfb: Fix dereference before NULL check

info->par is dereferenced before info is checked for NULL. Fix.

Coverity Bug 833

Signed-off-by: Antonino Daplas <adaplas@pol.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

drivers/video/arcfb.c

diff --git a/drivers/video/arcfb.c b/drivers/video/arcfb.c
index 0cf26da..4660428 100644
--- a/drivers/video/arcfb.c
+++ b/drivers/video/arcfb.c
@@ -459,11 +459,11 @@
 	inode = file->f_dentry->d_inode;
 	fbidx = iminor(inode);
 	info = registered_fb[fbidx];
-	par = info->par;
 
 	if (!info || !info->screen_base)
 		return -ENODEV;
 
+	par = info->par;
 	xres = info->var.xres;
 	fbmemlength = (xres * info->var.yres)/8;