commit 3aa4614da741f10b09559a5675c79e2eff5cccd8
author Patrick McHardy <kaber@trash.net> Thu Nov 20 04:07:14 2008 -0800
committer David S. Miller <davem@davemloft.net> Thu Nov 20 04:07:14 2008 -0800
tree 0181c697123716bf574e7819854d373dc6ee18b8
parent f7f65d1e8bfaa92c1a419c2a52faeca835659295

pkt_sched: fix missing check for packet overrun in qdisc_dump_stab()

nla_nest_start() might return NULL, causing a NULL pointer dereference.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

net/sched/sch_api.c

diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
index b16ad29..6ab4a2f 100644
--- a/net/sched/sch_api.c
+++ b/net/sched/sch_api.c
@@ -417,6 +417,8 @@
 	struct nlattr *nest;
 
 	nest = nla_nest_start(skb, TCA_STAB);
+	if (nest == NULL)
+		goto nla_put_failure;
 	NLA_PUT(skb, TCA_STAB_BASE, sizeof(stab->szopts), &stab->szopts);
 	nla_nest_end(skb, nest);