commit 3939fcde24473dc09ce16e922c88df9b3bee45d9
author Li Zefan <lizf@cn.fujitsu.com> Wed Apr 08 15:06:12 2009 +0800
committer Al Viro <viro@zeniv.linux.org.uk> Mon Apr 20 23:02:50 2009 -0400
tree fe1525d311cad56f25323a659e6c1811b22c0a8d
parent 3eac8778a237d83a1e553eba0c6f4fd4b39eeec0

xattr: use memdup_user()

Remove open-coded memdup_user()

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

fs/xattr.c

diff --git a/fs/xattr.c b/fs/xattr.c
index 197c4fc..d51b8f9 100644
--- a/fs/xattr.c
+++ b/fs/xattr.c
@@ -237,13 +237,9 @@
 	if (size) {
 		if (size > XATTR_SIZE_MAX)
 			return -E2BIG;
-		kvalue = kmalloc(size, GFP_KERNEL);
-		if (!kvalue)
-			return -ENOMEM;
-		if (copy_from_user(kvalue, value, size)) {
-			kfree(kvalue);
-			return -EFAULT;
-		}
+		kvalue = memdup_user(value, size);
+		if (IS_ERR(kvalue))
+			return PTR_ERR(kvalue);
 	}
 
 	error = vfs_setxattr(d, kname, kvalue, size, flags);