tree 1ec45ae9721da85fb3807003067dd6be2b73a96d
parent 0d0fb0f9c5fddef4a10242fe3337f00f528a3099
author Neil Brown <neilb@suse.de> 1271729812 +1000
committer J. Bruce Fields <bfields@citi.umich.edu> 1272310748 -0400

nfsd4: bug in read_buf

When read_buf is called to move over to the next page in the pagelist
of an NFSv4 request, it sets argp->end to essentially a random
number, certainly not an address within the page which argp->p now
points to.  So subsequent calls to READ_BUF will think there is much
more than a page of spare space (the cast to u32 ensures an unsigned
comparison) so we can expect to fall off the end of the second
page.

We never encountered thsi in testing because typically the only
operations which use more than two pages are write-like operations,
which have their own decoding logic.  Something like a getattr after a
write may cross a page boundary, but it would be very unusual for it to
cross another boundary after that.

Cc: stable@kernel.org
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>