tree a629a5c25caf3880a23bda9af4404c86a8a5ad00
parent 762faaed91e4ea4a3c34bc58f3221d9487acb470
author Alan Cox <alan@linux.intel.com> 1245168093 +0100
committer Linus Torvalds <torvalds@linux-foundation.org> 1245178876 -0700

tty: fix sanity check

The WARN_ON() that was added to tty_reopen can be triggered in the specific
case of a hangup occurring during a re-open of a tty which is not in the
middle of being otherwise closed.

In that case however the WARN() is bogus as we don't hold the neccessary
locks to make a correct decision.

The case we should be checking is "if the ldisc is not changing and reopen
is occuring". We could drop the WARN_ON but for the moment the debug is more
valuable even if it means taking a mutex as it will find any other cases.

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>