tree b2714e30224746ceea6d4e84acf9d8a33b09d300
parent 1ecc09e765d3ae16ef42a4d454836d9ed804fd18
author Julia Lawall <julia@diku.dk> 1261513903 +0100
committer Samuel Ortiz <sameo@linux.intel.com> 1267996615 +0100

mfd: Correct use after free for t7l66xb

The structure t7l66xb should not be freed before the subsequent references
to its fields in the arguments to clk_put.  Furthermore, this structure is
allocated near the beginning of the function, and a goto to the label
err_noirq appears after a successful allocation, so it would seem that the
kfree should be moved down below this label.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x,e;
identifier f;
iterator I;
statement S;
@@

*kfree(x);
... when != &x
    when != x = e
    when != I(x,...) S
*x->f
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>