commit 08ffce4560e0133e10634b0dd85eecee11257a1c
author Dmitry Torokhov <dtor_core@ameritech.net> Mon Jun 26 01:45:10 2006 -0400
committer Dmitry Torokhov <dtor_core@ameritech.net> Mon Jun 26 01:45:10 2006 -0400
tree eff2a0266e0897e72e48db949fb28f367812222e
parent 4854c7b27f0975a2b629f35ea3996d2968eb7c4f

Input: fix potential overflows in driver/input/mouse

Change all sprintfs into snprintfs to make sure we won't stomp on
data adjacent to our buffers.

Noticed by Wouter Paesen <wouter@kangaroot.net>

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

drivers/input/mouse/alps.c

diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
index a0e2e79..070d753 100644
--- a/drivers/input/mouse/alps.c
+++ b/drivers/input/mouse/alps.c
@@ -470,7 +470,7 @@
 		dev1->keybit[LONG(BTN_BACK)] |= BIT(BTN_BACK);
 	}
 
-	sprintf(priv->phys, "%s/input1", psmouse->ps2dev.serio->phys);
+	snprintf(priv->phys, sizeof(priv->phys), "%s/input1", psmouse->ps2dev.serio->phys);
 	dev2->phys = priv->phys;
 	dev2->name = (priv->i->flags & ALPS_DUALPOINT) ? "DualPoint Stick" : "PS/2 Mouse";
 	dev2->id.bustype = BUS_I8042;