)]}' { "commit": "9e30175a769245d19e4a8e5c5df39c9adabab087", "tree": "12263edd3a4c1b5384a0f76989a19c7013a82fa6", "parents": [ "68a96de45d479b6354b04aa5ccdbdc5535245b68" ], "author": { "name": "Mike Frysinger", "email": "vapier@gentoo.org", "time": "Mon Aug 13 08:09:52 2012 -0700" }, "committer": { "name": "Stephen Hemminger", "email": "shemminger@vyatta.com", "time": "Mon Aug 13 08:12:57 2012 -0700" }, "message": "Fix regression with \u0027ip address show\u0027\n\n`ip a s` no longer shows addresses since 3.4.0 works, but 3.5.0,\n\nthe simple test case:\nmake clean \u0026\u0026 make -j -s \u0026\u0026 ./ip/ip a s lo\n\nbefore that change, i would get:\n1: lo: \u003cLOOPBACK,UP,LOWER_UP\u003e mtu 16436 qdisc noqueue state UNKNOWN\n link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00\n inet 127.0.0.1/8 scope host lo\n inet6 ::1/128 scope host\n valid_lft forever preferred_lft forever\n\nbut after, i now get:\n1: lo: \u003cLOOPBACK,UP,LOWER_UP\u003e mtu 16436 qdisc noqueue state UNKNOWN\n link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00\n\nseems like the bug was introduced in the middle of that patch:\n\n-\tif (filter.family !\u003d AF_PACKET) {\n+\tif (filter.family \u0026\u0026 filter.family !\u003d AF_PACKET) {\n+\t\tif (filter.oneline)\n+\t\t\tno_link \u003d 1;\n+\n \t\tif (rtnl_wilddump_request(\u0026rth, filter.family, RTM_GETADDR) \u003c 0) {\n \t\t\tperror(\"Cannot send dump request\");\n \t\t\texit(1);\n\nif i revert the change to the if statement there, `ip a s` works for me again.\n", "tree_diff": [ { "type": "modify", "old_id": "37deda50ae40a4c4385158e0b009c3a345f0fce5", "old_mode": 33188, "old_path": "ip/ipaddress.c", "new_id": "69a63b3142f3d2340d2ee0bd6fb17516e0515559", "new_mode": 33188, "new_path": "ip/ipaddress.c" } ] }