commit 99500b56d94dfa735a3d088fdbdde6c0c2638e78
author Fan Du <fan.du@windriver.com> Mon Sep 30 21:09:05 2013 -0700
committer Stephen Hemminger <stephen@networkplumber.org> Mon Sep 30 21:09:05 2013 -0700
tree 20d68ff187e73d4bcfab7872d5b61c7b32840d9c
parent 101847446e6a5e3ca370e65ebc462584934fce0e

xfrm: use memcpy to suppress gcc phony buffer overflow warning.

This bug is reported from below link:
https://bugzilla.redhat.com/show_bug.cgi?id=982761

An simplified command from its original reproducing method in bugzilla:
ip xfrm state add src 10.0.0.2 dst 10.0.0.1 proto ah spi 0x12345678 auth md5 12
will cause below spew from gcc.

Reported-by: Sohny Thomas <sthomas@linux.vnet.ibm.com>

ip/xfrm_state.c

diff --git a/ip/xfrm_state.c b/ip/xfrm_state.c
index 389942c..f4ad4cb 100644
--- a/ip/xfrm_state.c
+++ b/ip/xfrm_state.c
@@ -162,7 +162,7 @@
 			if (len > max)
 				invarg("ALGO-KEYMAT value makes buffer overflow\n", key);
 
-			strncpy(buf, key, len);
+			memcpy(buf, key, len);
 		}
 	}