)]}' { "commit": "3bed7bb7e73894b949e4fd875f1712f4cf8b4655", "tree": "32f05d1c14ecd92e47b515ace4d3f1af142b04b5", "parents": [ "257422f77fc2a11429a3f86dea0a740752d15d19" ], "author": { "name": "Kees van Reeuwijk", "email": "reeuwijk@few.vu.nl", "time": "Tue Feb 19 07:46:04 2013 +0000" }, "committer": { "name": "Stephen Hemminger", "email": "stephen@networkplumber.org", "time": "Thu Feb 21 08:34:34 2013 -0800" }, "message": "iproute2: clearer error messages for fifo and tbf qdiscs\n\nClearer error messages for fifo and tbf qdiscs:\n- Say who is complaining\n- Don\u0027t just say a parameter is bad, show the offending parameter\n- Be clearer about duplicate parameters vs illegal pairs of parameters\n- Try to give multiple error messages rather than let the user discover the errors one by one\n- When there are parameter aliases, try to use the variant that was used, or at least mention them all\n\nNote that in the old version an empty parameter list to tbf would just cause an explain() message\nwithout a specific error message. By simply removing the relevant error check, the code now\nhandles this error more gracefully by printing an error message for all mandatory parameters.\nIt still prints the explain() message.\n\nSigned-off-by: Kees van Reeuwijk \u003creeuwijk@few.vu.nl\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "6242a98b76259b54f1d7891aa0bbaf8441e6caca", "old_mode": 33188, "old_path": "tc/q_fifo.c", "new_id": "c9ab123f0b5d50661e71d33f1786b4729abf45a8", "new_mode": 33188, "new_path": "tc/q_fifo.c" }, { "type": "modify", "old_id": "dc556fe01d745fe808d0db0fe192dae5a9beb609", "old_mode": 33188, "old_path": "tc/q_tbf.c", "new_id": "72cfff669faa4b4a387d296c2f23be42e1bc5b96", "new_mode": 33188, "new_path": "tc/q_tbf.c" } ] }