tree 0b9a3667fc03451781cb5e4ce5c2c8394d19c507
parent 301307952288e563850ae8216a36d689837463e5
author Jonathan Nieder <jrnieder@gmail.com> 1575538243 -0800
committer Jonathan Nieder <jrnieder@gmail.com> 1575964695 +0000

fsck: reject submodule.update = !command in .gitmodules

commit bb92255ebe6bccd76227e023d6d0bc997e318ad0 upstream.

This allows hosting providers to detect whether they are being used
to attack users using malicious 'update = !command' settings in
.gitmodules.

Since ac1fbbda2013 (submodule: do not copy unknown update mode from
.gitmodules, 2013-12-02), in normal cases such settings have been
treated as 'update = none', so forbidding them should not produce any
collateral damage to legitimate uses.  A quick search does not reveal
any repositories making use of this construct, either.

Reported-by: Joern Schneeweisz <jschneeweisz@gitlab.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>