Google Git
Sign in
googlers / jrn / git / c74faea19e39ca933492f697596310397175c329
commitc74faea19e39ca933492f697596310397175c329[log] [tgz]
authorNicolas Pitre <nico@cam.org>Tue Dec 09 14:26:52 2008 -0500
committerJunio C Hamano <gitster@pobox.com>Wed Dec 10 17:56:05 2008 -0800
tree8d98539f02bf7bcc82c43f466feae01dbf0de9bc
parentaa971cb9bf4105eefb435b9e6f282f019529c35f [diff]
make sure packs to be replaced are closed beforehand

Especially on Windows where an opened file cannot be replaced, make
sure pack-objects always close packs it is about to replace. Even on
non Windows systems, this could save potential bad results if ever
objects were to be read from the new pack file using offset from the old
index.

This should fix t5303 on Windows.

Signed-off-by: Nicolas Pitre <nico@cam.org>
Tested-by: Johannes Sixt <j6t@kdbg.org> (MinGW)
Signed-off-by: Junio C Hamano <gitster@pobox.com>
3 files changed
tree: 8d98539f02bf7bcc82c43f466feae01dbf0de9bc
  1. arm/
  2. compat/
  3. contrib/
  4. Documentation/
  5. git-gui/
  6. gitk-git/
  7. gitweb/
  8. mozilla-sha1/
  9. perl/
  10. ppc/
  11. t/
  12. templates/
  13. xdiff/
  14. RelNotes ⇨ Documentation/RelNotes-1.6.0.5.txt
  15. .gitattributes
  16. .gitignore
  17. .mailmap
  18. abspath.c
  19. alias.c
  20. alloc.c
  21. archive-tar.c
  22. archive-zip.c
  23. archive.c
  24. archive.h
  25. attr.c
  26. attr.h
  27. base85.c
  28. blob.c
  29. blob.h
  30. branch.c
  31. branch.h
  32. builtin-add.c
  33. builtin-annotate.c
  34. builtin-apply.c
  35. builtin-archive.c
  36. builtin-blame.c
  37. builtin-branch.c
  38. builtin-bundle.c
  39. builtin-cat-file.c
  40. builtin-check-attr.c
  41. builtin-check-ref-format.c
  42. builtin-checkout-index.c
  43. builtin-checkout.c
  44. builtin-clean.c
  45. builtin-clone.c
  46. builtin-commit-tree.c
  47. builtin-commit.c
  48. builtin-config.c
  49. builtin-count-objects.c
  50. builtin-describe.c
  51. builtin-diff-files.c
  52. builtin-diff-index.c
  53. builtin-diff-tree.c
  54. builtin-diff.c
  55. builtin-fast-export.c
  56. builtin-fetch--tool.c
  57. builtin-fetch-pack.c
  58. builtin-fetch.c
  59. builtin-fmt-merge-msg.c
  60. builtin-for-each-ref.c
  61. builtin-fsck.c
  62. builtin-gc.c
  63. builtin-grep.c
  64. builtin-http-fetch.c
  65. builtin-init-db.c
  66. builtin-log.c
  67. builtin-ls-files.c
  68. builtin-ls-remote.c
  69. builtin-ls-tree.c
  70. builtin-mailinfo.c
  71. builtin-mailsplit.c
  72. builtin-merge-base.c
  73. builtin-merge-file.c
  74. builtin-merge-ours.c
  75. builtin-merge-recursive.c
  76. builtin-merge.c
  77. builtin-mv.c
  78. builtin-name-rev.c
  79. builtin-pack-objects.c
  80. builtin-pack-refs.c
  81. builtin-prune-packed.c
  82. builtin-prune.c
  83. builtin-push.c
  84. builtin-read-tree.c
  85. builtin-reflog.c
  86. builtin-remote.c
  87. builtin-rerere.c
  88. builtin-reset.c
  89. builtin-rev-list.c
  90. builtin-rev-parse.c
  91. builtin-revert.c
  92. builtin-rm.c
  93. builtin-send-pack.c
  94. builtin-shortlog.c
  95. builtin-show-branch.c
  96. builtin-show-ref.c
  97. builtin-stripspace.c
  98. builtin-symbolic-ref.c
  99. builtin-tag.c
  100. builtin-tar-tree.c
  101. builtin-unpack-objects.c
  102. builtin-update-index.c
  103. builtin-update-ref.c
  104. builtin-upload-archive.c
  105. builtin-verify-pack.c
  106. builtin-verify-tag.c
  107. builtin-write-tree.c
  108. builtin.h
  109. bundle.c
  110. bundle.h
  111. cache-tree.c
  112. cache-tree.h
  113. cache.h
  114. check-builtins.sh
  115. check-racy.c
  116. check_bindir
  117. color.c
  118. color.h
  119. combine-diff.c
  120. command-list.txt
  121. commit.c
  122. commit.h
  123. config.c
  124. config.mak.in
  125. configure.ac
  126. connect.c
  127. convert.c
  128. copy.c
  129. COPYING
  130. csum-file.c
  131. csum-file.h
  132. ctype.c
  133. daemon.c
  134. date.c
  135. decorate.c
  136. decorate.h
  137. delta.h
  138. diff-delta.c
  139. diff-lib.c
  140. diff-no-index.c
  141. diff.c
  142. diff.h
  143. diffcore-break.c
  144. diffcore-delta.c
  145. diffcore-order.c
  146. diffcore-pickaxe.c
  147. diffcore-rename.c
  148. diffcore.h
  149. dir.c
  150. dir.h
  151. dump-cache-tree.c
  152. editor.c
  153. entry.c
  154. environment.c
  155. exec_cmd.c
  156. exec_cmd.h
  157. fast-import.c
  158. fetch-pack.h
  159. fixup-builtins
  160. fsck.c
  161. fsck.h
  162. generate-cmdlist.sh
  163. git-add--interactive.perl
  164. git-am.sh
  165. git-archimport.perl
  166. git-bisect.sh
  167. git-compat-util.h
  168. git-cvsexportcommit.perl
  169. git-cvsimport.perl
  170. git-cvsserver.perl
  171. git-filter-branch.sh
  172. git-instaweb.sh
  173. git-lost-found.sh
  174. git-merge-octopus.sh
  175. git-merge-one-file.sh
  176. git-merge-resolve.sh
  177. git-mergetool.sh
  178. git-parse-remote.sh
  179. git-pull.sh
  180. git-quiltimport.sh
  181. git-rebase--interactive.sh
  182. git-rebase.sh
  183. git-relink.perl
  184. git-repack.sh
  185. git-request-pull.sh
  186. git-send-email.perl
  187. git-sh-setup.sh
  188. git-stash.sh
  189. git-submodule.sh
  190. git-svn.perl
  191. GIT-VERSION-GEN
  192. git-web--browse.sh
  193. git.c
  194. git.spec.in
  195. graph.c
  196. graph.h
  197. grep.c
  198. grep.h
  199. hash-object.c
  200. hash.c
  201. hash.h
  202. help.c
  203. http-push.c
  204. http-walker.c
  205. http.c
  206. http.h
  207. ident.c
  208. imap-send.c
  209. index-pack.c
  210. INSTALL
  211. interpolate.c
  212. interpolate.h
  213. list-objects.c
  214. list-objects.h
  215. ll-merge.c
  216. ll-merge.h
  217. lockfile.c
  218. log-tree.c
  219. log-tree.h
  220. mailmap.c
  221. mailmap.h
  222. Makefile
  223. match-trees.c
  224. merge-file.c
  225. merge-index.c
  226. merge-recursive.h
  227. merge-tree.c
  228. mktag.c
  229. mktree.c
  230. name-hash.c
  231. object.c
  232. object.h
  233. pack-check.c
  234. pack-redundant.c
  235. pack-refs.c
  236. pack-refs.h
  237. pack-revindex.c
  238. pack-revindex.h
  239. pack-write.c
  240. pack.h
  241. pager.c
  242. parse-options.c
  243. parse-options.h
  244. patch-delta.c
  245. patch-id.c
  246. patch-ids.c
  247. patch-ids.h
  248. path.c
  249. pkt-line.c
  250. pkt-line.h
  251. pretty.c
  252. progress.c
  253. progress.h
  254. quote.c
  255. quote.h
  256. reachable.c
  257. reachable.h
  258. read-cache.c
  259. README
  260. receive-pack.c
  261. reflog-walk.c
  262. reflog-walk.h
  263. refs.c
  264. refs.h
  265. remote.c
  266. remote.h
  267. rerere.c
  268. rerere.h
  269. revision.c
  270. revision.h
  271. run-command.c
  272. run-command.h
  273. send-pack.h
  274. server-info.c
  275. setup.c
  276. sha1-lookup.c
  277. sha1-lookup.h
  278. sha1_file.c
  279. sha1_name.c
  280. shallow.c
  281. shell.c
  282. shortlog.h
  283. show-index.c
  284. sideband.c
  285. sideband.h
  286. strbuf.c
  287. strbuf.h
  288. string-list.c
  289. string-list.h
  290. symlinks.c
  291. tag.c
  292. tag.h
  293. tar.h
  294. test-chmtime.c
  295. test-date.c
  296. test-delta.c
  297. test-genrandom.c
  298. test-match-trees.c
  299. test-parse-options.c
  300. test-path-utils.c
  301. test-sha1.c
  302. test-sha1.sh
  303. thread-utils.c
  304. thread-utils.h
  305. trace.c
  306. transport.c
  307. transport.h
  308. tree-diff.c
  309. tree-walk.c
  310. tree-walk.h
  311. tree.c
  312. tree.h
  313. unpack-file.c
  314. unpack-trees.c
  315. unpack-trees.h
  316. update-server-info.c
  317. upload-pack.c
  318. usage.c
  319. utf8.c
  320. utf8.h
  321. var.c
  322. walker.c
  323. walker.h
  324. wrapper.c
  325. write_or_die.c
  326. ws.c
  327. wt-status.c
  328. wt-status.h
  329. xdiff-interface.c
  330. xdiff-interface.h