commit beed7e22fdc81ba325c4bfaadf84d23f5c697d93
author Junio C Hamano <gitster@pobox.com> Wed Apr 25 13:29:03 2018 +0900
committer Junio C Hamano <gitster@pobox.com> Wed Apr 25 13:29:03 2018 +0900
tree 9f81c2ef32e4f0eab2883419c292513ef2772531
parent 3a940e90d505a3f2ea20e5ebc5b7acad131ad204
parent d8579accfaea398a157a3a8ad2ca6cac25f1b999

Merge branch 'bp/fsmonitor-bufsize-fix'

Fix an unexploitable (because the oversized contents are not under
attacker's control) buffer overflow.

* bp/fsmonitor-bufsize-fix:
  fsmonitor: fix incorrect buffer size when printing version number

fsmonitor.c

diff --git a/fsmonitor.c b/fsmonitor.c
index 6d7bcd5..eb4e642 100644
--- a/fsmonitor.c
+++ b/fsmonitor.c
@@ -104,7 +104,7 @@ static int query_fsmonitor(int version, uint64_t last_update, struct strbuf *que
 	if (!(argv[0] = core_fsmonitor))
 		return -1;
 
-	snprintf(ver, sizeof(version), "%d", version);
+	snprintf(ver, sizeof(ver), "%d", version);
 	snprintf(date, sizeof(date), "%" PRIuMAX, (uintmax_t)last_update);
 	argv[1] = ver;
 	argv[2] = date;