blame: reject empty ranges -LX,+0 and -LX,-0
Empty ranges -LX,+0 and -LX,-0 are nonsensical in the context of blame
yet they are accepted (in fact, both are interpreted as -LX,+2). Report
them as invalid.
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff --git a/line-range.c b/line-range.c
index 3942475..a816951 100644
--- a/line-range.c
+++ b/line-range.c
@@ -26,6 +26,8 @@
if (term != spec + 1) {
if (!ret)
return term;
+ if (num == 0)
+ die("-L invalid empty range");
if (spec[0] == '-')
num = 0 - num;
if (0 < num)
diff --git a/t/annotate-tests.sh b/t/annotate-tests.sh
index bbf3ee6..cd9222b 100644
--- a/t/annotate-tests.sh
+++ b/t/annotate-tests.sh
@@ -185,7 +185,7 @@
check_count -L6,3 B 1 B1 1 B2 1 D 1
'
-test_expect_failure 'blame -L X,+0' '
+test_expect_success 'blame -L X,+0' '
test_must_fail $PROG -L1,+0 file
'
@@ -197,7 +197,7 @@
check_count -L3,+4 B 1 B1 1 B2 1 D 1
'
-test_expect_failure 'blame -L X,-0' '
+test_expect_success 'blame -L X,-0' '
test_must_fail $PROG -L1,-0 file
'
