tree 22eda8e78a72863e9458d8c798e0b373f02d0daa
parent b1a01e1c0762d117da7dac009b773f310479be12
author Julian Phillips <julian@quantumfyre.co.uk> 1258147556 +0000
committer Junio C Hamano <gitster@pobox.com> 1258243386 -0800

remote: fix use-after-free error detected by glibc in ref_remove_duplicates

In ref_remove_duplicates, when we encounter a duplicate and remove it
from the list we need to make sure that the prev pointer stays
pointing at the last entry and also skip over adding the just freed
entry to the string_list.

Previously fetch could crash with:
*** glibc detected *** git: corrupted double-linked list: ...

Also add a test to try and catch problems with duplicate removal in
the future.

Acked-by: Nicolas Pitre <nico@fluxnic.net>
Signed-off-by: Julian Phillips <julian@quantumfyre.co.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>