commit 90a734dc7f37a7bd1f3beec4d33acad559360f6c
author Yasushi SHOJI <yashi@atmark-techno.com> Sun Aug 21 16:14:16 2005 +0900
committer Junio C Hamano <junkio@cox.net> Sun Aug 21 03:48:33 2005 -0700
tree 34b0a955c4a5e14ab4687b4762f8dd06e04e5111
parent d57306c7945becfba70d3139af0a3a8f525a6bb5

[PATCH] possible memory leak in diff.c::diff_free_filepair()

Here is a patch to fix the problem in the simplest way.

diff.c

diff --git a/diff.c b/diff.c
index bb2a43b..137d0d0 100644
--- a/diff.c
+++ b/diff.c
@@ -1010,9 +1010,8 @@
 			diff_flush_name(p, line_termination);
 			break;
 		}
-	}
-	for (i = 0; i < q->nr; i++)
 		diff_free_filepair(q->queue[i]);
+	}
 	free(q->queue);
 	q->queue = NULL;
 	q->nr = q->alloc = 0;