commit 89f3bbdd3b1f46a5747aa5618b7742f7b3f2adef
author brian m. carlson <sandals@crustytoothpaste.net> Sun Oct 15 22:06:53 2017 +0000
committer Junio C Hamano <gitster@pobox.com> Mon Oct 16 11:05:50 2017 +0900
tree e8345a55653b4f286a86bde54f44244b4fcc2201
parent 6ee18216d8d9ca8f76b01282b36bdf590a64d8fc

refs: update ref transactions to use struct object_id

Update the ref transaction code to use struct object_id.  Remove one
NULL pointer check which was previously inserted around a dereference;
since we now pass a pointer to struct object_id directly through, the
code we're calling handles this for us.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

builtin/commit.c

diff --git a/builtin/commit.c b/builtin/commit.c
index d75b380..f9c9676 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -1788,9 +1788,9 @@ int cmd_commit(int argc, const char **argv, const char *prefix)
 
 	transaction = ref_transaction_begin(&err);
 	if (!transaction ||
-	    ref_transaction_update(transaction, "HEAD", oid.hash,
+	    ref_transaction_update(transaction, "HEAD", &oid,
 				   current_head
-				   ? current_head->object.oid.hash : null_sha1,
+				   ? &current_head->object.oid : &null_oid,
 				   0, sb.buf, &err) ||
 	    ref_transaction_commit(transaction, &err)) {
 		rollback_index_files();