Google Git
Sign in
googlers / jrn / git / 7ba502c47bda21d060844863991083f4c319d436
commit7ba502c47bda21d060844863991083f4c319d436[log] [tgz]
authorNicolas Pitre <nico@cam.org>Tue Oct 16 21:55:48 2007 -0400
committerShawn O. Pearce <spearce@spearce.org>Wed Oct 17 02:54:56 2007 -0400
tree200952ea673cdf589e161de938c2012c5351de72
parent2f8b89472cec19a530cb697c4ee20e0ddfd747f6 [diff]
pack-objects.c: fix some global variable abuse and memory leaks

To keep things well layered, sha1close() now returns the file descriptor
when it doesn't close the file.

An ugly cast was added to the return of write_idx_file() to avoid a
warning.  A proper fix will come separately.

Signed-off-by: Nicolas Pitre <nico@cam.org>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
2 files changed
tree: 200952ea673cdf589e161de938c2012c5351de72
  1. arm/
  2. compat/
  3. contrib/
  4. Documentation/
  5. git-gui/
  6. gitweb/
  7. mozilla-sha1/
  8. perl/
  9. ppc/
  10. t/
  11. templates/
  12. xdiff/
  13. RelNotes ⇨ Documentation/RelNotes-1.5.4.txt
  14. .gitignore
  15. .mailmap
  16. alloc.c
  17. archive-tar.c
  18. archive-zip.c
  19. archive.h
  20. attr.c
  21. attr.h
  22. base85.c
  23. blob.c
  24. blob.h
  25. builtin-add.c
  26. builtin-annotate.c
  27. builtin-apply.c
  28. builtin-archive.c
  29. builtin-blame.c
  30. builtin-branch.c
  31. builtin-bundle.c
  32. builtin-cat-file.c
  33. builtin-check-attr.c
  34. builtin-check-ref-format.c
  35. builtin-checkout-index.c
  36. builtin-commit-tree.c
  37. builtin-config.c
  38. builtin-count-objects.c
  39. builtin-describe.c
  40. builtin-diff-files.c
  41. builtin-diff-index.c
  42. builtin-diff-tree.c
  43. builtin-diff.c
  44. builtin-fetch--tool.c
  45. builtin-fmt-merge-msg.c
  46. builtin-for-each-ref.c
  47. builtin-fsck.c
  48. builtin-gc.c
  49. builtin-grep.c
  50. builtin-init-db.c
  51. builtin-log.c
  52. builtin-ls-files.c
  53. builtin-ls-tree.c
  54. builtin-mailinfo.c
  55. builtin-mailsplit.c
  56. builtin-merge-base.c
  57. builtin-merge-file.c
  58. builtin-mv.c
  59. builtin-name-rev.c
  60. builtin-pack-objects.c
  61. builtin-pack-refs.c
  62. builtin-prune-packed.c
  63. builtin-prune.c
  64. builtin-push.c
  65. builtin-read-tree.c
  66. builtin-reflog.c
  67. builtin-rerere.c
  68. builtin-reset.c
  69. builtin-rev-list.c
  70. builtin-rev-parse.c
  71. builtin-revert.c
  72. builtin-rm.c
  73. builtin-runstatus.c
  74. builtin-shortlog.c
  75. builtin-show-branch.c
  76. builtin-show-ref.c
  77. builtin-stripspace.c
  78. builtin-symbolic-ref.c
  79. builtin-tag.c
  80. builtin-tar-tree.c
  81. builtin-unpack-objects.c
  82. builtin-update-index.c
  83. builtin-update-ref.c
  84. builtin-upload-archive.c
  85. builtin-verify-pack.c
  86. builtin-verify-tag.c
  87. builtin-write-tree.c
  88. builtin.h
  89. cache-tree.c
  90. cache-tree.h
  91. cache.h
  92. check-builtins.sh
  93. check-racy.c
  94. color.c
  95. color.h
  96. combine-diff.c
  97. commit.c
  98. commit.h
  99. config.c
  100. config.mak.in
  101. configure.ac
  102. connect.c
  103. convert.c
  104. copy.c
  105. COPYING
  106. csum-file.c
  107. csum-file.h
  108. ctype.c
  109. daemon.c
  110. date.c
  111. decorate.c
  112. decorate.h
  113. delta.h
  114. diff-delta.c
  115. diff-lib.c
  116. diff.c
  117. diff.h
  118. diffcore-break.c
  119. diffcore-delta.c
  120. diffcore-order.c
  121. diffcore-pickaxe.c
  122. diffcore-rename.c
  123. diffcore.h
  124. dir.c
  125. dir.h
  126. dump-cache-tree.c
  127. entry.c
  128. environment.c
  129. exec_cmd.c
  130. exec_cmd.h
  131. fast-import.c
  132. fetch-pack.c
  133. fetch.c
  134. fetch.h
  135. fixup-builtins
  136. generate-cmdlist.sh
  137. git-add--interactive.perl
  138. git-am.sh
  139. git-archimport.perl
  140. git-bisect.sh
  141. git-checkout.sh
  142. git-clean.sh
  143. git-clone.sh
  144. git-commit.sh
  145. git-compat-util.h
  146. git-cvsexportcommit.perl
  147. git-cvsimport.perl
  148. git-cvsserver.perl
  149. git-fetch.sh
  150. git-filter-branch.sh
  151. git-instaweb.sh
  152. git-lost-found.sh
  153. git-ls-remote.sh
  154. git-merge-octopus.sh
  155. git-merge-one-file.sh
  156. git-merge-ours.sh
  157. git-merge-resolve.sh
  158. git-merge-stupid.sh
  159. git-merge.sh
  160. git-mergetool.sh
  161. git-parse-remote.sh
  162. git-pull.sh
  163. git-quiltimport.sh
  164. git-rebase--interactive.sh
  165. git-rebase.sh
  166. git-relink.perl
  167. git-remote.perl
  168. git-repack.sh
  169. git-request-pull.sh
  170. git-send-email.perl
  171. git-sh-setup.sh
  172. git-stash.sh
  173. git-submodule.sh
  174. git-svn.perl
  175. git-svnimport.perl
  176. GIT-VERSION-GEN
  177. git.c
  178. git.spec.in
  179. gitk
  180. grep.c
  181. grep.h
  182. hash-object.c
  183. help.c
  184. http-fetch.c
  185. http-push.c
  186. http.c
  187. http.h
  188. ident.c
  189. imap-send.c
  190. index-pack.c
  191. INSTALL
  192. interpolate.c
  193. interpolate.h
  194. list-objects.c
  195. list-objects.h
  196. local-fetch.c
  197. lockfile.c
  198. log-tree.c
  199. log-tree.h
  200. mailmap.c
  201. mailmap.h
  202. Makefile
  203. match-trees.c
  204. merge-file.c
  205. merge-index.c
  206. merge-recursive.c
  207. merge-tree.c
  208. mktag.c
  209. mktree.c
  210. object-refs.c
  211. object.c
  212. object.h
  213. pack-check.c
  214. pack-redundant.c
  215. pack-write.c
  216. pack.h
  217. pager.c
  218. patch-delta.c
  219. patch-id.c
  220. patch-ids.c
  221. patch-ids.h
  222. path-list.c
  223. path-list.h
  224. path.c
  225. peek-remote.c
  226. pkt-line.c
  227. pkt-line.h
  228. progress.c
  229. progress.h
  230. quote.c
  231. quote.h
  232. reachable.c
  233. reachable.h
  234. read-cache.c
  235. README
  236. receive-pack.c
  237. reflog-walk.c
  238. reflog-walk.h
  239. refs.c
  240. refs.h
  241. remote.c
  242. remote.h
  243. revision.c
  244. revision.h
  245. rsh.c
  246. rsh.h
  247. run-command.c
  248. run-command.h
  249. send-pack.c
  250. server-info.c
  251. setup.c
  252. sha1_file.c
  253. sha1_name.c
  254. shallow.c
  255. shell.c
  256. show-index.c
  257. sideband.c
  258. sideband.h
  259. ssh-fetch.c
  260. ssh-pull.c
  261. ssh-push.c
  262. ssh-upload.c
  263. strbuf.c
  264. strbuf.h
  265. symlinks.c
  266. tag.c
  267. tag.h
  268. tar.h
  269. test-absolute-path.c
  270. test-chmtime.c
  271. test-date.c
  272. test-delta.c
  273. test-genrandom.c
  274. test-match-trees.c
  275. test-sha1.c
  276. test-sha1.sh
  277. trace.c
  278. tree-diff.c
  279. tree-walk.c
  280. tree-walk.h
  281. tree.c
  282. tree.h
  283. unpack-file.c
  284. unpack-trees.c
  285. unpack-trees.h
  286. update-server-info.c
  287. upload-pack.c
  288. usage.c
  289. utf8.c
  290. utf8.h
  291. var.c
  292. write_or_die.c
  293. wt-status.c
  294. wt-status.h
  295. xdiff-interface.c
  296. xdiff-interface.h