tree 5e125bd4e64bc924c39fe0b70ef69cb336f7d784
parent 7e2010537e96d0a1144520222f20ba1dc3d61441
author Thomas Rast <trast@inf.ethz.ch> 1366106265 +0200
committer Junio C Hamano <gitster@pobox.com> 1366136268 -0700

read_revisions_from_stdin: make copies for handle_revision_arg

read_revisions_from_stdin() has passed pointers to its read buffer
down to handle_revision_arg() since its inception way back in 42cabc3
(Teach rev-list an option to read revs from the standard input.,
2006-09-05).  Even back then, this was a bug: through
add_pending_object, the argument was recorded in the object_array's
'name' field.

Fix it by making a copy whenever read_revisions_from_stdin() passes an
argument down the callchain.  The other caller runs handle_revision_arg()
on argv[], where it would be redundant to make a copy.

Signed-off-by: Thomas Rast <trast@inf.ethz.ch>
Signed-off-by: Junio C Hamano <gitster@pobox.com>