commit 6073b3b5c37716c50244d635e7c358f41f43e286
author Patrick Steinhardt <ps@pks.im> Mon May 27 13:46:15 2024 +0200
committer Junio C Hamano <gitster@pobox.com> Mon May 27 11:19:59 2024 -0700
tree 6d3663eeb79e31b729d5a51ef9028ccb58848d3e
parent f962ffc392fe1831d047a10a28a55710d987d746

config: clarify memory ownership in `git_config_pathname()`

The out parameter of `git_config_pathname()` is a `const char **` even
though we transfer ownership of memory to the caller. This is quite
misleading and has led to many memory leaks all over the place. Adapt
the parameter to instead be `char **`.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff.c

diff --git a/diff.c b/diff.c
index ded9ac7..902df92 100644
--- a/diff.c
+++ b/diff.c
@@ -58,7 +58,7 @@ static int diff_context_default = 3;
 static int diff_interhunk_context_default;
 static const char *diff_word_regex_cfg;
 static const char *external_diff_cmd_cfg;
-static const char *diff_order_file_cfg;
+static char *diff_order_file_cfg;
 int diff_auto_refresh_index = 1;
 static int diff_mnemonic_prefix;
 static int diff_no_prefix;