Google Git
Sign in
googlers / jrn / git / 598354c0ad4198daff279c34a96f42e4d91fb4e6
commit598354c0ad4198daff279c34a96f42e4d91fb4e6[log] [tgz]
authorBrandon Casey <drafnel@gmail.com>Sat Jan 26 11:14:32 2013 -0800
committerJunio C Hamano <gitster@pobox.com>Sat Jan 26 19:00:03 2013 -0800
tree02e6f8947cf8af3f89ee82172396765e1aab0c5c
parent5d417842efeafb6e109db7574196901c4e95d273 [diff]
git-p4.py: support Python 2.5

Python 2.5 and older do not accept None as the first argument to
translate() and complain with:

   TypeError: expected a character buffer object

As suggested by Pete Wyckoff, let's just replace the call to translate()
with a regex search which should be more clear and more portable.

This allows git-p4 to be used with Python 2.5.

Signed-off-by: Brandon Casey <bcasey@nvidia.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2 files changed
tree: 02e6f8947cf8af3f89ee82172396765e1aab0c5c
  1. block-sha1/
  2. builtin/
  3. compat/
  4. contrib/
  5. Documentation/
  6. git-gui/
  7. git_remote_helpers/
  8. gitk-git/
  9. gitweb/
  10. mergetools/
  11. perl/
  12. po/
  13. ppc/
  14. t/
  15. templates/
  16. vcs-svn/
  17. xdiff/
  18. RelNotes ⇨ Documentation/RelNotes/1.8.1.txt
  19. .gitattributes
  20. .gitignore
  21. .mailmap
  22. abspath.c
  23. aclocal.m4
  24. advice.c
  25. advice.h
  26. alias.c
  27. alloc.c
  28. archive-tar.c
  29. archive-zip.c
  30. archive.c
  31. archive.h
  32. argv-array.c
  33. argv-array.h
  34. attr.c
  35. attr.h
  36. base85.c
  37. bisect.c
  38. bisect.h
  39. blob.c
  40. blob.h
  41. branch.c
  42. branch.h
  43. builtin.h
  44. bulk-checkin.c
  45. bulk-checkin.h
  46. bundle.c
  47. bundle.h
  48. cache-tree.c
  49. cache-tree.h
  50. cache.h
  51. check-builtins.sh
  52. check-racy.c
  53. check_bindir
  54. color.c
  55. color.h
  56. column.c
  57. column.h
  58. combine-diff.c
  59. command-list.txt
  60. commit.c
  61. commit.h
  62. config.c
  63. config.mak.in
  64. configure.ac
  65. connect.c
  66. connected.c
  67. connected.h
  68. convert.c
  69. convert.h
  70. copy.c
  71. COPYING
  72. credential-cache--daemon.c
  73. credential-cache.c
  74. credential-store.c
  75. credential.c
  76. credential.h
  77. csum-file.c
  78. csum-file.h
  79. ctype.c
  80. daemon.c
  81. date.c
  82. decorate.c
  83. decorate.h
  84. delta.h
  85. diff-delta.c
  86. diff-lib.c
  87. diff-no-index.c
  88. diff.c
  89. diff.h
  90. diffcore-break.c
  91. diffcore-delta.c
  92. diffcore-order.c
  93. diffcore-pickaxe.c
  94. diffcore-rename.c
  95. diffcore.h
  96. dir.c
  97. dir.h
  98. editor.c
  99. entry.c
  100. environment.c
  101. exec_cmd.c
  102. exec_cmd.h
  103. fast-import.c
  104. fetch-pack.c
  105. fetch-pack.h
  106. fixup-builtins
  107. fmt-merge-msg.h
  108. fsck.c
  109. fsck.h
  110. generate-cmdlist.sh
  111. gettext.c
  112. gettext.h
  113. git-add--interactive.perl
  114. git-am.sh
  115. git-archimport.perl
  116. git-bisect.sh
  117. git-compat-util.h
  118. git-cvsexportcommit.perl
  119. git-cvsimport.perl
  120. git-cvsserver.perl
  121. git-difftool--helper.sh
  122. git-difftool.perl
  123. git-filter-branch.sh
  124. git-instaweb.sh
  125. git-lost-found.sh
  126. git-merge-octopus.sh
  127. git-merge-one-file.sh
  128. git-merge-resolve.sh
  129. git-mergetool--lib.sh
  130. git-mergetool.sh
  131. git-p4.py
  132. git-parse-remote.sh
  133. git-pull.sh
  134. git-quiltimport.sh
  135. git-rebase--am.sh
  136. git-rebase--interactive.sh
  137. git-rebase--merge.sh
  138. git-rebase.sh
  139. git-relink.perl
  140. git-remote-testgit.py
  141. git-repack.sh
  142. git-request-pull.sh
  143. git-send-email.perl
  144. git-sh-i18n.sh
  145. git-sh-setup.sh
  146. git-stash.sh
  147. git-submodule.sh
  148. git-svn.perl
  149. GIT-VERSION-GEN
  150. git-web--browse.sh
  151. git.c
  152. git.spec.in
  153. gpg-interface.c
  154. gpg-interface.h
  155. graph.c
  156. graph.h
  157. grep.c
  158. grep.h
  159. hash.c
  160. hash.h
  161. help.c
  162. help.h
  163. hex.c
  164. http-backend.c
  165. http-fetch.c
  166. http-push.c
  167. http-walker.c
  168. http.c
  169. http.h
  170. ident.c
  171. imap-send.c
  172. INSTALL
  173. kwset.c
  174. kwset.h
  175. levenshtein.c
  176. levenshtein.h
  177. LGPL-2.1
  178. list-objects.c
  179. list-objects.h
  180. ll-merge.c
  181. ll-merge.h
  182. lockfile.c
  183. log-tree.c
  184. log-tree.h
  185. mailmap.c
  186. mailmap.h
  187. Makefile
  188. match-trees.c
  189. merge-file.c
  190. merge-file.h
  191. merge-recursive.c
  192. merge-recursive.h
  193. merge.c
  194. mergesort.c
  195. mergesort.h
  196. name-hash.c
  197. notes-cache.c
  198. notes-cache.h
  199. notes-merge.c
  200. notes-merge.h
  201. notes.c
  202. notes.h
  203. object.c
  204. object.h
  205. pack-check.c
  206. pack-refs.c
  207. pack-refs.h
  208. pack-revindex.c
  209. pack-revindex.h
  210. pack-write.c
  211. pack.h
  212. pager.c
  213. parse-options-cb.c
  214. parse-options.c
  215. parse-options.h
  216. patch-delta.c
  217. patch-ids.c
  218. patch-ids.h
  219. path.c
  220. pkt-line.c
  221. pkt-line.h
  222. preload-index.c
  223. pretty.c
  224. progress.c
  225. progress.h
  226. prompt.c
  227. prompt.h
  228. quote.c
  229. quote.h
  230. reachable.c
  231. reachable.h
  232. read-cache.c
  233. README
  234. reflog-walk.c
  235. reflog-walk.h
  236. refs.c
  237. refs.h
  238. remote-curl.c
  239. remote-testsvn.c
  240. remote.c
  241. remote.h
  242. replace_object.c
  243. rerere.c
  244. rerere.h
  245. resolve-undo.c
  246. resolve-undo.h
  247. revision.c
  248. revision.h
  249. run-command.c
  250. run-command.h
  251. send-pack.c
  252. send-pack.h
  253. sequencer.c
  254. sequencer.h
  255. server-info.c
  256. setup.c
  257. sh-i18n--envsubst.c
  258. sha1-array.c
  259. sha1-array.h
  260. sha1-lookup.c
  261. sha1-lookup.h
  262. sha1_file.c
  263. sha1_name.c
  264. shallow.c
  265. shell.c
  266. shortlog.h
  267. show-index.c
  268. sideband.c
  269. sideband.h
  270. sigchain.c
  271. sigchain.h
  272. strbuf.c
  273. strbuf.h
  274. streaming.c
  275. streaming.h
  276. string-list.c
  277. string-list.h
  278. submodule.c
  279. submodule.h
  280. symlinks.c
  281. tag.c
  282. tag.h
  283. tar.h
  284. test-chmtime.c
  285. test-ctype.c
  286. test-date.c
  287. test-delta.c
  288. test-dump-cache-tree.c
  289. test-genrandom.c
  290. test-index-version.c
  291. test-line-buffer.c
  292. test-match-trees.c
  293. test-mergesort.c
  294. test-mktemp.c
  295. test-parse-options.c
  296. test-path-utils.c
  297. test-regex.c
  298. test-revision-walking.c
  299. test-run-command.c
  300. test-scrap-cache-tree.c
  301. test-sha1.c
  302. test-sha1.sh
  303. test-sigchain.c
  304. test-string-list.c
  305. test-subprocess.c
  306. test-svn-fe.c
  307. thread-utils.c
  308. thread-utils.h
  309. trace.c
  310. transport-helper.c
  311. transport.c
  312. transport.h
  313. tree-diff.c
  314. tree-walk.c
  315. tree-walk.h
  316. tree.c
  317. tree.h
  318. unimplemented.sh
  319. unix-socket.c
  320. unix-socket.h
  321. unpack-trees.c
  322. unpack-trees.h
  323. upload-pack.c
  324. url.c
  325. url.h
  326. usage.c
  327. userdiff.c
  328. userdiff.h
  329. utf8.c
  330. utf8.h
  331. varint.c
  332. varint.h
  333. version.c
  334. version.h
  335. walker.c
  336. walker.h
  337. wrap-for-bin.sh
  338. wrapper.c
  339. write_or_die.c
  340. ws.c
  341. wt-status.c
  342. wt-status.h
  343. xdiff-interface.c
  344. xdiff-interface.h
  345. zlib.c