tree ef588c2b3f8f787ab317f157d30dc9f30e18eec7
parent c2a499e6c31ed613a606ffdeb5bb74ab41e9a586
author Jeff King <peff@peff.net> 1522434886 -0400
committer Junio C Hamano <gitster@pobox.com> 1522439397 -0700

set_git_dir: die when setenv() fails

The set_git_dir() function returns an error if setenv()
fails, but there are zero callers who pay attention to this
return value. If this ever were to happen, it could cause
confusing results, as sub-processes would see a potentially
stale GIT_DIR (e.g., if it is relative and we chdir()-ed to
the root of the working tree).

We _could_ try to fix each caller, but there's really
nothing useful to do after this failure except die. Let's
just lump setenv() failure into the same category as malloc
failure: things that should never happen and cause us to
abort catastrophically.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>