Google Git
Sign in
googlers / jrn / git / 4491e62ae932d5774f628d1bd3be663c11058a73
commit4491e62ae932d5774f628d1bd3be663c11058a73[log] [tgz]
authorShawn O. Pearce <spearce@spearce.org>Tue Sep 25 00:13:25 2007 -0400
committerJunio C Hamano <gitster@pobox.com>Mon Sep 24 23:25:26 2007 -0700
tree4a47cf0b2da34de6a673703e388dadd3442c1a6b
parent7dfee372b08f653c2709c90bea986e4ed608f410 [diff]
Prevent send-pack from segfaulting when a branch doesn't match

If `git push url foo` can't find a local branch named foo we can't
match it to any remote branch as the local branch is NULL and its
name is probably at position 0x34 in memory.  On most systems that
isn't a valid address for git-send-pack's virtual address space
and we segfault.

If we can't find a source match and we have no destination we
need to abort the match function early before we try to match the
destination against the remote.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 file changed
tree: 4a47cf0b2da34de6a673703e388dadd3442c1a6b
  1. arm/
  2. compat/
  3. contrib/
  4. Documentation/
  5. git-gui/
  6. gitweb/
  7. mozilla-sha1/
  8. perl/
  9. ppc/
  10. t/
  11. templates/
  12. xdiff/
  13. RelNotes ⇨ Documentation/RelNotes-1.5.4.txt
  14. .gitignore
  15. .mailmap
  16. alloc.c
  17. archive-tar.c
  18. archive-zip.c
  19. archive.h
  20. attr.c
  21. attr.h
  22. base85.c
  23. blob.c
  24. blob.h
  25. builtin-add.c
  26. builtin-annotate.c
  27. builtin-apply.c
  28. builtin-archive.c
  29. builtin-blame.c
  30. builtin-branch.c
  31. builtin-bundle.c
  32. builtin-cat-file.c
  33. builtin-check-attr.c
  34. builtin-check-ref-format.c
  35. builtin-checkout-index.c
  36. builtin-commit-tree.c
  37. builtin-config.c
  38. builtin-count-objects.c
  39. builtin-describe.c
  40. builtin-diff-files.c
  41. builtin-diff-index.c
  42. builtin-diff-tree.c
  43. builtin-diff.c
  44. builtin-fetch--tool.c
  45. builtin-fetch-pack.c
  46. builtin-fetch.c
  47. builtin-fmt-merge-msg.c
  48. builtin-for-each-ref.c
  49. builtin-fsck.c
  50. builtin-gc.c
  51. builtin-grep.c
  52. builtin-http-fetch.c
  53. builtin-init-db.c
  54. builtin-log.c
  55. builtin-ls-files.c
  56. builtin-ls-tree.c
  57. builtin-mailinfo.c
  58. builtin-mailsplit.c
  59. builtin-merge-base.c
  60. builtin-merge-file.c
  61. builtin-mv.c
  62. builtin-name-rev.c
  63. builtin-pack-objects.c
  64. builtin-pack-refs.c
  65. builtin-prune-packed.c
  66. builtin-prune.c
  67. builtin-push.c
  68. builtin-read-tree.c
  69. builtin-reflog.c
  70. builtin-rerere.c
  71. builtin-reset.c
  72. builtin-rev-list.c
  73. builtin-rev-parse.c
  74. builtin-revert.c
  75. builtin-rm.c
  76. builtin-runstatus.c
  77. builtin-shortlog.c
  78. builtin-show-branch.c
  79. builtin-show-ref.c
  80. builtin-stripspace.c
  81. builtin-symbolic-ref.c
  82. builtin-tag.c
  83. builtin-tar-tree.c
  84. builtin-unpack-objects.c
  85. builtin-update-index.c
  86. builtin-update-ref.c
  87. builtin-upload-archive.c
  88. builtin-verify-pack.c
  89. builtin-verify-tag.c
  90. builtin-write-tree.c
  91. builtin.h
  92. bundle.c
  93. bundle.h
  94. cache-tree.c
  95. cache-tree.h
  96. cache.h
  97. check-builtins.sh
  98. check-racy.c
  99. color.c
  100. color.h
  101. combine-diff.c
  102. commit.c
  103. commit.h
  104. config.c
  105. config.mak.in
  106. configure.ac
  107. connect.c
  108. convert-objects.c
  109. convert.c
  110. copy.c
  111. COPYING
  112. csum-file.c
  113. csum-file.h
  114. ctype.c
  115. daemon.c
  116. date.c
  117. decorate.c
  118. decorate.h
  119. delta.h
  120. diff-delta.c
  121. diff-lib.c
  122. diff.c
  123. diff.h
  124. diffcore-break.c
  125. diffcore-delta.c
  126. diffcore-order.c
  127. diffcore-pickaxe.c
  128. diffcore-rename.c
  129. diffcore.h
  130. dir.c
  131. dir.h
  132. dump-cache-tree.c
  133. entry.c
  134. environment.c
  135. exec_cmd.c
  136. exec_cmd.h
  137. fast-import.c
  138. fetch-pack.h
  139. fixup-builtins
  140. generate-cmdlist.sh
  141. git-add--interactive.perl
  142. git-am.sh
  143. git-archimport.perl
  144. git-bisect.sh
  145. git-checkout.sh
  146. git-clean.sh
  147. git-clone.sh
  148. git-commit.sh
  149. git-compat-util.h
  150. git-cvsexportcommit.perl
  151. git-cvsimport.perl
  152. git-cvsserver.perl
  153. git-filter-branch.sh
  154. git-instaweb.sh
  155. git-lost-found.sh
  156. git-ls-remote.sh
  157. git-merge-octopus.sh
  158. git-merge-one-file.sh
  159. git-merge-ours.sh
  160. git-merge-resolve.sh
  161. git-merge-stupid.sh
  162. git-merge.sh
  163. git-mergetool.sh
  164. git-parse-remote.sh
  165. git-pull.sh
  166. git-quiltimport.sh
  167. git-rebase--interactive.sh
  168. git-rebase.sh
  169. git-relink.perl
  170. git-remote.perl
  171. git-repack.sh
  172. git-request-pull.sh
  173. git-send-email.perl
  174. git-sh-setup.sh
  175. git-stash.sh
  176. git-submodule.sh
  177. git-svn.perl
  178. git-svnimport.perl
  179. GIT-VERSION-GEN
  180. git.c
  181. git.spec.in
  182. gitk
  183. grep.c
  184. grep.h
  185. hash-object.c
  186. help.c
  187. http-push.c
  188. http-walker.c
  189. http.c
  190. http.h
  191. ident.c
  192. imap-send.c
  193. index-pack.c
  194. INSTALL
  195. interpolate.c
  196. interpolate.h
  197. list-objects.c
  198. list-objects.h
  199. lockfile.c
  200. log-tree.c
  201. log-tree.h
  202. mailmap.c
  203. mailmap.h
  204. Makefile
  205. match-trees.c
  206. merge-file.c
  207. merge-index.c
  208. merge-recursive.c
  209. merge-tree.c
  210. mktag.c
  211. mktree.c
  212. object-refs.c
  213. object.c
  214. object.h
  215. pack-check.c
  216. pack-redundant.c
  217. pack-write.c
  218. pack.h
  219. pager.c
  220. patch-delta.c
  221. patch-id.c
  222. patch-ids.c
  223. patch-ids.h
  224. path-list.c
  225. path-list.h
  226. path.c
  227. peek-remote.c
  228. pkt-line.c
  229. pkt-line.h
  230. progress.c
  231. progress.h
  232. quote.c
  233. quote.h
  234. reachable.c
  235. reachable.h
  236. read-cache.c
  237. README
  238. receive-pack.c
  239. reflog-walk.c
  240. reflog-walk.h
  241. refs.c
  242. refs.h
  243. remote.c
  244. remote.h
  245. revision.c
  246. revision.h
  247. run-command.c
  248. run-command.h
  249. send-pack.c
  250. server-info.c
  251. setup.c
  252. sha1_file.c
  253. sha1_name.c
  254. shallow.c
  255. shell.c
  256. show-index.c
  257. sideband.c
  258. sideband.h
  259. strbuf.c
  260. strbuf.h
  261. symlinks.c
  262. tag.c
  263. tag.h
  264. tar.h
  265. test-absolute-path.c
  266. test-chmtime.c
  267. test-date.c
  268. test-delta.c
  269. test-genrandom.c
  270. test-match-trees.c
  271. test-sha1.c
  272. test-sha1.sh
  273. trace.c
  274. transport.c
  275. transport.h
  276. tree-diff.c
  277. tree-walk.c
  278. tree-walk.h
  279. tree.c
  280. tree.h
  281. unpack-file.c
  282. unpack-trees.c
  283. unpack-trees.h
  284. update-server-info.c
  285. upload-pack.c
  286. usage.c
  287. utf8.c
  288. utf8.h
  289. var.c
  290. walker.c
  291. walker.h
  292. write_or_die.c
  293. wt-status.c
  294. wt-status.h
  295. xdiff-interface.c
  296. xdiff-interface.h