[PATCH] diff: fix the culling of unneeded delete record.
The commit 15d061b435a7e3b6bead39df3889f4af78c4b00a
[PATCH] Fix the way diffcore-rename records unremoved source.
still leaves unneeded delete records in its output stream by
mistake, which was covered up by having an extra check to turn
such a delete into a no-op downstream. Fix the check in the
diffcore-rename to simplify the output routine.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
diff --git a/diff.c b/diff.c
index 919280d..a080d94 100644
--- a/diff.c
+++ b/diff.c
@@ -792,27 +792,8 @@
p->status = 'U';
else if (!DIFF_FILE_VALID(p->one))
p->status = 'N';
- else if (!DIFF_FILE_VALID(p->two)) {
- /* Deleted entry may have been picked up by
- * another rename-copy entry. So we scan the
- * queue and if we find one that uses us as the
- * source we do not say delete for this entry.
- */
- for (j = 0; j < q->nr; j++) {
- pp = q->queue[j];
- if (!strcmp(p->one->path, pp->one->path) &&
- DIFF_PAIR_RENAME(pp)) {
- /* rename/copy are always valid
- * so we do not say DIFF_FILE_VALID()
- * on pp->one and pp->two.
- */
- p->status = 'X';
- break;
- }
- }
- if (!p->status)
- p->status = 'D';
- }
+ else if (!DIFF_FILE_VALID(p->two))
+ p->status = 'D';
else if (DIFF_PAIR_TYPE_CHANGED(p))
p->status = 'T';
