commit 1d2f80fa79cdc6f7f4fa1cefb47d7d19be3bc5ee
author Julian Phillips <julian@quantumfyre.co.uk> Sat Jun 26 00:41:38 2010 +0100
committer Junio C Hamano <gitster@pobox.com> Sun Jun 27 10:06:52 2010 -0700
tree ddad96762347505bb9b455b2e891f74b0b320f99
parent e8c8b7139c87c3e3017d3bff07f91c4349850d58

string_list: Fix argument order for string_list_append

Update the definition and callers of string_list_append to use the
string_list as the first argument.  This helps make the string_list
API easier to use by being more consistent.

Signed-off-by: Julian Phillips <julian@quantumfyre.co.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

builtin/fetch.c

diff --git a/builtin/fetch.c b/builtin/fetch.c
index 9165bb6..c5e24b5 100644
--- a/builtin/fetch.c
+++ b/builtin/fetch.c
@@ -745,7 +745,7 @@
 {
 	struct string_list *list = priv;
 	if (!remote->skip_default_update)
-		string_list_append(remote->name, list);
+		string_list_append(list, remote->name);
 	return 0;
 }
 
@@ -764,8 +764,8 @@
 		int space = strcspn(value, " \t\n");
 		while (*value) {
 			if (space > 1) {
-				string_list_append(xstrndup(value, space),
-						   g->list);
+				string_list_append(g->list,
+						   xstrndup(value, space));
 			}
 			value += space + (value[space] != '\0');
 			space = strcspn(value, " \t\n");
@@ -786,7 +786,7 @@
 		if (!remote_is_configured(name))
 			return 0;
 		remote = remote_get(name);
-		string_list_append(remote->name, list);
+		string_list_append(list, remote->name);
 	}
 	return 1;
 }