Google Git
Sign in
googlers / jrn / git / c0582c53bcf4e83bba70e1ad23abbad31f96ebc8
commitc0582c53bcf4e83bba70e1ad23abbad31f96ebc8[log] [tgz]
authorErik Faye-Lund <kusmabite@gmail.com>Mon Mar 23 12:53:08 2009 +0000
committerJunio C Hamano <gitster@pobox.com>Sun Mar 29 19:48:43 2009 -0700
treebd5a8222f3352aba250a1777a764ccffc194e330
parent2d07f6d4b728d19d115b89123224268718f34efd [diff]
builtin-fast-export.c: fix crash on tagged trees

If a tag object points to a tree (or another unhandled type), the commit-
pointer is left uninitialized and later dereferenced. This patch adds a
default case to the switch that issues a warning and skips the object.

Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2 files changed
tree: bd5a8222f3352aba250a1777a764ccffc194e330
  1. arm/
  2. compat/
  3. contrib/
  4. Documentation/
  5. git-gui/
  6. gitk-git/
  7. gitweb/
  8. mozilla-sha1/
  9. perl/
  10. ppc/
  11. t/
  12. templates/
  13. xdiff/
  14. RelNotes ⇨ Documentation/RelNotes-1.6.3.txt
  15. .gitattributes
  16. .gitignore
  17. .mailmap
  18. abspath.c
  19. alias.c
  20. alloc.c
  21. archive-tar.c
  22. archive-zip.c
  23. archive.c
  24. archive.h
  25. attr.c
  26. attr.h
  27. base85.c
  28. blob.c
  29. blob.h
  30. branch.c
  31. branch.h
  32. builtin-add.c
  33. builtin-annotate.c
  34. builtin-apply.c
  35. builtin-archive.c
  36. builtin-blame.c
  37. builtin-branch.c
  38. builtin-bundle.c
  39. builtin-cat-file.c
  40. builtin-check-attr.c
  41. builtin-check-ref-format.c
  42. builtin-checkout-index.c
  43. builtin-checkout.c
  44. builtin-clean.c
  45. builtin-clone.c
  46. builtin-commit-tree.c
  47. builtin-commit.c
  48. builtin-config.c
  49. builtin-count-objects.c
  50. builtin-describe.c
  51. builtin-diff-files.c
  52. builtin-diff-index.c
  53. builtin-diff-tree.c
  54. builtin-diff.c
  55. builtin-fast-export.c
  56. builtin-fetch--tool.c
  57. builtin-fetch-pack.c
  58. builtin-fetch.c
  59. builtin-fmt-merge-msg.c
  60. builtin-for-each-ref.c
  61. builtin-fsck.c
  62. builtin-gc.c
  63. builtin-grep.c
  64. builtin-help.c
  65. builtin-http-fetch.c
  66. builtin-init-db.c
  67. builtin-log.c
  68. builtin-ls-files.c
  69. builtin-ls-remote.c
  70. builtin-ls-tree.c
  71. builtin-mailinfo.c
  72. builtin-mailsplit.c
  73. builtin-merge-base.c
  74. builtin-merge-file.c
  75. builtin-merge-ours.c
  76. builtin-merge-recursive.c
  77. builtin-merge.c
  78. builtin-mv.c
  79. builtin-name-rev.c
  80. builtin-pack-objects.c
  81. builtin-pack-refs.c
  82. builtin-prune-packed.c
  83. builtin-prune.c
  84. builtin-push.c
  85. builtin-read-tree.c
  86. builtin-receive-pack.c
  87. builtin-reflog.c
  88. builtin-remote.c
  89. builtin-rerere.c
  90. builtin-reset.c
  91. builtin-rev-list.c
  92. builtin-rev-parse.c
  93. builtin-revert.c
  94. builtin-rm.c
  95. builtin-send-pack.c
  96. builtin-shortlog.c
  97. builtin-show-branch.c
  98. builtin-show-ref.c
  99. builtin-stripspace.c
  100. builtin-symbolic-ref.c
  101. builtin-tag.c
  102. builtin-tar-tree.c
  103. builtin-unpack-objects.c
  104. builtin-update-index.c
  105. builtin-update-ref.c
  106. builtin-upload-archive.c
  107. builtin-verify-pack.c
  108. builtin-verify-tag.c
  109. builtin-write-tree.c
  110. builtin.h
  111. bundle.c
  112. bundle.h
  113. cache-tree.c
  114. cache-tree.h
  115. cache.h
  116. check-builtins.sh
  117. check-racy.c
  118. check_bindir
  119. color.c
  120. color.h
  121. combine-diff.c
  122. command-list.txt
  123. commit.c
  124. commit.h
  125. config.c
  126. config.mak.in
  127. configure.ac
  128. connect.c
  129. convert.c
  130. copy.c
  131. COPYING
  132. csum-file.c
  133. csum-file.h
  134. ctype.c
  135. daemon.c
  136. date.c
  137. decorate.c
  138. decorate.h
  139. delta.h
  140. diff-delta.c
  141. diff-lib.c
  142. diff-no-index.c
  143. diff.c
  144. diff.h
  145. diffcore-break.c
  146. diffcore-delta.c
  147. diffcore-order.c
  148. diffcore-pickaxe.c
  149. diffcore-rename.c
  150. diffcore.h
  151. dir.c
  152. dir.h
  153. editor.c
  154. entry.c
  155. environment.c
  156. exec_cmd.c
  157. exec_cmd.h
  158. fast-import.c
  159. fetch-pack.h
  160. fixup-builtins
  161. fsck.c
  162. fsck.h
  163. generate-cmdlist.sh
  164. git-add--interactive.perl
  165. git-am.sh
  166. git-archimport.perl
  167. git-bisect.sh
  168. git-compat-util.h
  169. git-cvsexportcommit.perl
  170. git-cvsimport.perl
  171. git-cvsserver.perl
  172. git-filter-branch.sh
  173. git-instaweb.sh
  174. git-lost-found.sh
  175. git-merge-octopus.sh
  176. git-merge-one-file.sh
  177. git-merge-resolve.sh
  178. git-mergetool.sh
  179. git-parse-remote.sh
  180. git-pull.sh
  181. git-quiltimport.sh
  182. git-rebase--interactive.sh
  183. git-rebase.sh
  184. git-relink.perl
  185. git-repack.sh
  186. git-request-pull.sh
  187. git-send-email.perl
  188. git-sh-setup.sh
  189. git-stash.sh
  190. git-submodule.sh
  191. git-svn.perl
  192. GIT-VERSION-GEN
  193. git-web--browse.sh
  194. git.c
  195. git.spec.in
  196. graph.c
  197. graph.h
  198. grep.c
  199. grep.h
  200. hash-object.c
  201. hash.c
  202. hash.h
  203. help.c
  204. help.h
  205. http-push.c
  206. http-walker.c
  207. http.c
  208. http.h
  209. ident.c
  210. imap-send.c
  211. index-pack.c
  212. INSTALL
  213. levenshtein.c
  214. levenshtein.h
  215. list-objects.c
  216. list-objects.h
  217. ll-merge.c
  218. ll-merge.h
  219. lockfile.c
  220. log-tree.c
  221. log-tree.h
  222. mailmap.c
  223. mailmap.h
  224. Makefile
  225. match-trees.c
  226. merge-file.c
  227. merge-index.c
  228. merge-recursive.c
  229. merge-recursive.h
  230. merge-tree.c
  231. mktag.c
  232. mktree.c
  233. name-hash.c
  234. object.c
  235. object.h
  236. pack-check.c
  237. pack-redundant.c
  238. pack-refs.c
  239. pack-refs.h
  240. pack-revindex.c
  241. pack-revindex.h
  242. pack-write.c
  243. pack.h
  244. pager.c
  245. parse-options.c
  246. parse-options.h
  247. patch-delta.c
  248. patch-id.c
  249. patch-ids.c
  250. patch-ids.h
  251. path.c
  252. pkt-line.c
  253. pkt-line.h
  254. preload-index.c
  255. pretty.c
  256. progress.c
  257. progress.h
  258. quote.c
  259. quote.h
  260. reachable.c
  261. reachable.h
  262. read-cache.c
  263. README
  264. reflog-walk.c
  265. reflog-walk.h
  266. refs.c
  267. refs.h
  268. remote.c
  269. remote.h
  270. rerere.c
  271. rerere.h
  272. revision.c
  273. revision.h
  274. run-command.c
  275. run-command.h
  276. send-pack.h
  277. server-info.c
  278. setup.c
  279. sha1-lookup.c
  280. sha1-lookup.h
  281. sha1_file.c
  282. sha1_name.c
  283. shallow.c
  284. shell.c
  285. shortlog.h
  286. show-index.c
  287. sideband.c
  288. sideband.h
  289. sigchain.c
  290. sigchain.h
  291. strbuf.c
  292. strbuf.h
  293. string-list.c
  294. string-list.h
  295. symlinks.c
  296. tag.c
  297. tag.h
  298. tar.h
  299. test-chmtime.c
  300. test-ctype.c
  301. test-date.c
  302. test-delta.c
  303. test-dump-cache-tree.c
  304. test-genrandom.c
  305. test-match-trees.c
  306. test-parse-options.c
  307. test-path-utils.c
  308. test-sha1.c
  309. test-sha1.sh
  310. test-sigchain.c
  311. thread-utils.c
  312. thread-utils.h
  313. trace.c
  314. transport.c
  315. transport.h
  316. tree-diff.c
  317. tree-walk.c
  318. tree-walk.h
  319. tree.c
  320. tree.h
  321. unpack-file.c
  322. unpack-trees.c
  323. unpack-trees.h
  324. update-server-info.c
  325. upload-pack.c
  326. usage.c
  327. userdiff.c
  328. userdiff.h
  329. utf8.c
  330. utf8.h
  331. var.c
  332. walker.c
  333. walker.h
  334. wrapper.c
  335. write_or_die.c
  336. ws.c
  337. wt-status.c
  338. wt-status.h
  339. xdiff-interface.c
  340. xdiff-interface.h