tree 2674373f9c6bc04ad6d7214ccb6d28a939702617
parent c3ff7be6fb04c3150a8496271901a4a918c2c70c
author Ævar Arnfjörð Bjarmason <avarab@gmail.com> 1632309590 +0200
committer Junio C Hamano <gitster@pobox.com> 1632352961 -0700

test-lib tests: avoid subshell for "test_cmp" for readability

The use of a sub-shell for running the test_cmp of stdout/stderr for
the test author was introduced in this form in 565b6fa87bb (tests:
refactor mechanics of testing in a sub test-lib, 2012-12-16), but from
looking at the history that seemed to have diligently copied my
original ad-hoc implementation in 7b905119703 (t/t0000-basic.sh: Run
the passing TODO test inside its own test-lib, 2010-08-19).

There's no reason to use a subshell here, we try to avoid it in
general. It also improves readability, if the test fails we print out
the relative path in the trash directory that needs to be looked
at.

Before that was mostly obscured, since the "write_sub_test_lib_test"
will pick the directory for you from the test name.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>