commit 066b70ae977b6481b15ebccb7c5deedf23c944ed
author Đoàn Trần Công Danh <congdanhqx@gmail.com> Fri May 08 00:51:02 2020 +0100
committer Junio C Hamano <gitster@pobox.com> Thu May 07 17:08:21 2020 -0700
tree 1c1fd3f5aa1afe3ad94b5ecd22b8f2064d57833d
parent 07d8ea56f2ecb64b75b92264770c0a664231ce17

bloom: fix `make sparse` warning

* We need a `final_new_line` to make our source code as text file, per
  POSIX and C specification.
* `bloom_filters` should be limited to interal linkage only

Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

bloom.c

diff --git a/bloom.c b/bloom.c
index dd9bab9..ee025e0 100644
--- a/bloom.c
+++ b/bloom.c
@@ -9,7 +9,7 @@
 
 define_commit_slab(bloom_filter_slab, struct bloom_filter);
 
-struct bloom_filter_slab bloom_filters;
+static struct bloom_filter_slab bloom_filters;
 
 struct pathmap_hash_entry {
     struct hashmap_entry entry;
@@ -273,4 +273,4 @@ int bloom_filter_contains(const struct bloom_filter *filter,
 	}
 
 	return 1;
-}
\ No newline at end of file
+}

bloom.h

diff --git a/bloom.h b/bloom.h
index b935186..e0e59e0 100644
--- a/bloom.h
+++ b/bloom.h
@@ -87,4 +87,4 @@ int bloom_filter_contains(const struct bloom_filter *filter,
 			  const struct bloom_key *key,
 			  const struct bloom_filter_settings *settings);
 
-#endif
\ No newline at end of file
+#endif

t/helper/test-bloom.c

diff --git a/t/helper/test-bloom.c b/t/helper/test-bloom.c
index 77eb27a..456f5ea 100644
--- a/t/helper/test-bloom.c
+++ b/t/helper/test-bloom.c
@@ -3,7 +3,7 @@
 #include "test-tool.h"
 #include "commit.h"
 
-struct bloom_filter_settings settings = DEFAULT_BLOOM_FILTER_SETTINGS;
+static struct bloom_filter_settings settings = DEFAULT_BLOOM_FILTER_SETTINGS;
 
 static void add_string_to_filter(const char *data, struct bloom_filter *filter) {
 		struct bloom_key key;

t/t0095-bloom.sh

diff --git a/t/t0095-bloom.sh b/t/t0095-bloom.sh
index 8f9eef1..809ec7b 100755
--- a/t/t0095-bloom.sh
+++ b/t/t0095-bloom.sh
@@ -114,4 +114,4 @@
 	test_cmp expect actual
 '
 
-test_done
\ No newline at end of file
+test_done

t/t4216-log-bloom.sh

diff --git a/t/t4216-log-bloom.sh b/t/t4216-log-bloom.sh
index c7011f3..21b68dd 100755
--- a/t/t4216-log-bloom.sh
+++ b/t/t4216-log-bloom.sh
@@ -152,4 +152,4 @@
 	test_bloom_filters_used_when_some_filters_are_missing "-- A/B"
 '
 
-test_done
\ No newline at end of file
+test_done